feat: upgrade dependencies; CNI 1.1.0 support #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Kreitzer <skre@skre.me>
|
Hey @s1061123 and @dougbtv, sorry, this is a pretty big PR due to upgrading vendor dependencies. I'm also not sure if this function is correct: https://github.com/buroa/multus-cni/blob/master/pkg/kubeletclient/kubeletclient.go#L159 |
|
mind breaking out the go.mod changes from the vendoring? thanks! |
|
@dougbtv Do you mean to not include any vendoring/dependency/go.mod updates? |
|
Hi, Thank you so much for your contribution, @buroa . Minor (but important) comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support CNI SPEC 1.1.0, with new CNI commands, GC and STATUS [on top of stale 1273]
I have also upgraded all vendor dependencies.
This is now required to work with
containerdv2.0.1+More info here: containerd/go-cni#123