Skips checking for readiness on CNI DEL #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
requested changes
Feb 21, 2024
dougbtv
force-pushed
the
remove-readiness-check-on-del
branch
3 times, most recently
from
1db7e61 to
a71a6bf
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dougbtv
force-pushed
the
remove-readiness-check-on-del
branch
2 times, most recently
from
3197182 to
89c64fd
Compare
| return false, fmt.Errorf("failed to get absolute path of readinessIndicatorFile: %v", err) | ||
| } | ||
|
|
||
| _, err = os.Stat(readinessIndicatorFile) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
There was a problem hiding this comment.
I tried to read up on this, and I think it wants you to limit it to a subset of directories given a "base path", but, that doesn't work here, and it's just a presence indicator, and not a destructive action, so it should be fine.
s1061123
reviewed
Feb 22, 2024
pkg/multus/multus.go
Outdated
| readinessfileexists, err := types.ReadinessIndicatorExistsNow(in.ReadinessIndicatorFile) | ||
| if err != nil { | ||
| return cmdErr(k8sArgs, "error checking readinessindicatorfile on CNI DEL @ %v: %v", in.ReadinessIndicatorFile, err) | ||
| } else { |
There was a problem hiding this comment.
As of test warning message in https://github.com/k8snetworkplumbingwg/multus-cni/pull/1235/files#annotation_18379130107 you can remove else block (because if clause ends with return, hence we don't need else block.
dougbtv
force-pushed
the
remove-readiness-check-on-del
branch
2 times, most recently
from
97a5552 to
6659929
Compare
Because deletes should favor a successful path, the readiness check should be skipped for pod removals. This can cause an issue where there's pods pending deletes and that might impact scheduling of a pod that may be necessary in order to set the readiness indicator. Adds a new method to check for readiness indicator alone in order to immediately log a warning.
dougbtv
force-pushed
the
remove-readiness-check-on-del
branch
from
6659929 to
a1915e1
Compare
s1061123
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because deletes should favor a successful path, the readiness check should be skipped for pod removals.
This can cause an issue where there's pods pending deletes and that might impact scheduling of a pod that may be necessary in order to set the readiness indicator.