Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the concept of scope. #663

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Add the concept of scope. #663

merged 9 commits into from
Oct 31, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Oct 30, 2023

ref: #545

And disallow remote reads and reads of directories above the working directory by default.

And disallow remote reads and reads of directories above the working directory by default.
@k1LoW k1LoW added enhancement New feature or request minor breaking-change labels Oct 30, 2023
@k1LoW k1LoW self-assigned this Oct 30, 2023
@k1LoW k1LoW marked this pull request as draft October 30, 2023 03:05
@github-actions

This comment has been minimized.

@k1LoW k1LoW marked this pull request as ready for review October 31, 2023 00:39
@k1LoW k1LoW requested a review from k2tzumi October 31, 2023 00:39
@github-actions
Copy link
Contributor

Code Metrics Report

main (4f85b8a) #663 (49c0caa) +/-
Coverage 70.0% 70.2% +0.2%
Code to Test Ratio 1:0.7 1:0.7 -0.0
Test Execution Time 3m20s 3m4s -16s
Details
  |                     | main (4f85b8a) | #663 (49c0caa) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          70.0% |          70.2% | +0.2% |
  |   Files             |             52 |             54 |    +2 |
  |   Lines             |           5735 |           5878 |  +143 |
+ |   Covered           |           4014 |           4128 |  +114 |
- | Code to Test Ratio  |          1:0.7 |          1:0.7 |  -0.0 |
  |   Code              |          11499 |          11738 |  +239 |
+ |   Test              |           8153 |           8209 |   +56 |
+ | Test Execution Time |          3m20s |           3m4s |  -16s |

Code coverage of files in pull request scope (71.9% → 72.5%)

Files Coverage +/-
book.go 73.2% +0.1%
operator.go 77.6% 0.0%
option.go 65.1% +2.3%
path.go 75.0% +4.7%
scope.go 75.0% +75.0%
testutil/port.go 0.0% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit d98c93d into main Oct 31, 2023
7 checks passed
@k1LoW k1LoW deleted the runbook-scope branch October 31, 2023 12:41
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
@k1LoW
Copy link
Owner Author

k1LoW commented Oct 31, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant