Listing variable expansion patterns in the Include runner. #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k2tzumi
reviewed
Oct 28, 2023
Comment on lines
+9
to
+15
| // If there is a variable expansion, it is reinterpreted in a form without quotes. | ||
| && vars.c == 12345 | ||
| && vars.d == 54321 | ||
| && vars.e == 123459 | ||
| && vars.f == 543219 | ||
| && vars.g == 912345 | ||
| && vars.h == 954321 |
There was a problem hiding this comment.
The following expectations were assumed
Suggested change
| // If there is a variable expansion, it is reinterpreted in a form without quotes. | |
| && vars.c == 12345 | |
| && vars.d == 54321 | |
| && vars.e == 123459 | |
| && vars.f == 543219 | |
| && vars.g == 912345 | |
| && vars.h == 954321 | |
| // If there is a variable expansion, it is reinterpreted in a form without quotes. | |
| && vars.c == 12345 | |
| && vars.d == "54321" | |
| && vars.e == "123459" | |
| && vars.f == "543219" | |
| && vars.g == "912345" | |
| && vars.h == "954321" |
There was a problem hiding this comment.
Then, if there is variable expansion, there is no way to pass numbers.
Code Metrics Report
Details | | main (067ca7a) | #661 (a5e7ab0) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 70.0% | 70.0% | +0.0% |
| Files | 52 | 52 | 0 |
| Lines | 5727 | 5727 | 0 |
+ | Covered | 4007 | 4008 | +1 |
| Code to Test Ratio | 1:0.7 | 1:0.7 | 0.0 |
| Code | 11489 | 11489 | 0 |
| Test | 8079 | 8079 | 0 |
+ | Test Execution Time | 5m41s | 4m45s | -56s |Reported by octocov |
k2tzumi
approved these changes
Oct 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #660
SSIA.