Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runbookID() for returning the runbook ID of the root runbook. #646

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Oct 17, 2023

@k1LoW k1LoW self-assigned this Oct 17, 2023
@github-actions

This comment has been minimized.

@k1LoW k1LoW marked this pull request as draft October 17, 2023 15:01
@k1LoW k1LoW marked this pull request as ready for review October 17, 2023 15:48
@k1LoW
Copy link
Owner Author

k1LoW commented Oct 17, 2023

@k2tzumi operator.runbookIDFull() and step.runbookIDFull() can be used to get the id needed for trace.

@k1LoW k1LoW requested a review from k2tzumi October 17, 2023 15:56
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@k1LoW k1LoW mentioned this pull request Oct 17, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Code Metrics Report

main (2a52af3) #646 (d2e78c5) +/-
Coverage 69.5% 69.7% +0.2%
Code to Test Ratio 1:0.7 1:0.7 -0.0
Test Execution Time 5m8s 2m47s -2m21s
Details
  |                     | main (2a52af3) | #646 (d2e78c5) |  +/-   |
  |---------------------|----------------|----------------|--------|
+ | Coverage            |          69.5% |          69.7% |  +0.2% |
  |   Files             |             51 |             51 |      0 |
  |   Lines             |           5546 |           5582 |    +36 |
+ |   Covered           |           3852 |           3888 |    +36 |
- | Code to Test Ratio  |          1:0.7 |          1:0.7 |   -0.0 |
  |   Code              |          11171 |          11249 |    +78 |
+ |   Test              |           7711 |           7750 |    +39 |
+ | Test Execution Time |           5m8s |          2m47s | -2m21s |

Code coverage of files in pull request scope (77.0% → 77.9%)

Files Coverage +/-
operator.go 77.1% +0.6%
step.go 95.7% -0.9%
trail.go 70.0% 0.0%

Reported by octocov

Copy link
Collaborator

@k2tzumi k2tzumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1LoW
Great!
LGTM!

@k1LoW k1LoW merged commit 730dbf9 into main Oct 19, 2023
7 checks passed
@k1LoW k1LoW deleted the run-id branch October 19, 2023 21:50
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants