Implement unordered container support, xhash no floating point #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for unordered containers (
unordered_map
,unordered_multimap
,unordered_set
, andunordered_multiset
).To do this I must patch
xhash
from the MSVC STL to eliminate the floating point arithmetic. I do this by copyingxhash
out of the MSVC STL and applying changes under the_XHASH_NO_FLOATING_POINT
define. I then directly include the patched version throughjxy/unordered_map.hpp
andjxy/unordered_set.hpp
defining_XHASH_NO_FLOATING_POINT
to1
before doing so.The solution here isn't ideal. I would much rather PR this into MSVC directly. I have a branch that does this for MSVC (microsoft/STL@main...jxy-s:xhash-no-floating-point) and I will engage with the MSVC community on it. However, the likelihood of this happening in a timely manner (if at all) is slim - it is, understandably, simply not a priority for them.