Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a unique_with item is blank, the rest of the items still should matter. #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

When a unique_with item is blank, the rest of the items still should matter. #24

wants to merge 2 commits into from

Conversation

flupzor
Copy link

@flupzor flupzor commented Mar 7, 2017

I think this should've been a continue, and not break from the for loop. Otherwise, i'm not sure why this should be the case.

@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 87.767% when pulling 1b4c960 on maykinmedia:multiple_unique_with into 2237710 on neithere:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flupzor @coveralls @shea-maykinmedia