Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: meta-trigger support of multiple GCP projects #28

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

feat: meta-trigger support of multiple GCP projects #28

wants to merge 35 commits into from

Conversation

jthegedus
Copy link
Owner

Since most GCP projects are repo -> multiple GCP projects, we want to deploy our CB Triggers to particular projects.

Should this be explicitly defined or not? IE: all projects unless a restriction specified. Or always expect a list of projects for each trigger?

Other changes:

  • use tabs over spaces (except CloudBuild yaml files as they should be spaces according to Google)
  • in yamlfiles, use list arrays for consistency
  • format with shfmt and editor config

@jthegedus jthegedus added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 2, 2020
@jthegedus jthegedus self-assigned this Jun 2, 2020
jthegedus added 24 commits June 3, 2020 18:31
@jthegedus
feat: download yq on build
497abed
@jthegedus
feat: use shfmt to test formatting
6d5fb38
@jthegedus
ci: test shfmt in CloudBuild
fd88fe3
@jthegedus
ci: shfmt functioned correctly
457886d
@jthegedus
ci: fix build dir of meta-triggers cb job
ac44a93
@jthegedus
fix: quote bash env var
e90913a
@jthegedus
fix: jq version
2eca200
@jthegedus
fix: show available jq versions
a51b7ee
@jthegedus
fix: echo dockerfile output for jq version printing
6071f1c
@jthegedus
fix: output jq versions after apt update
5ead469
@jthegedus
fix: jq version
04b68f4
@jthegedus
fix: show wget version
ec513d2
@jthegedus
fix: pin wget version
7f6ebab
@jthegedus
fix: meta-cloud-builder yq install and cb job dir
26d74d6
@jthegedus
feat: trigger-sync
f119c6e
@jthegedus
fix: lint dir for trigger-sync builder
1a1ddce
@jthegedus
fix: ci for trigger sync builder
c7d3f9e
@jthegedus
fix: ci trigger for trigger-sync builder
3ff8a90
@jthegedus
fix: use .bash suffix for meta cloud builder entrypoint script
5bff466
@jthegedus
fix: shellcheck .bash files
4a7baca
@jthegedus
fix: pass array to function bug
2fcb358
@jthegedus
ci: uplift test to build file
a80c813
@jthegedus
fix: required env var check
8484802
@jthegedus
fix: test trigger names
cc264da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jthegedus jthegedus

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jthegedus