Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Xcode CRuby settings into xcconfig #48

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Move Xcode CRuby settings into xcconfig #48

merged 6 commits into from
Apr 23, 2024

Conversation

johnfairh
Copy link
Owner

@johnfairh johnfairh commented Apr 18, 2024

Time to revamp the Ruby settings and glue.

Update CRuby to hold an xccconfig to have all the custom settings - I suppose I didn't know what xcconfig was back in the day.

Add xcodebuild tests to CI.

Remove refs to -fdeclspec now no longer needed.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (a20885b) to head (18bb2ec).
Report is 5 commits behind head on main.

❗ Current head 18bb2ec differs from pull request most recent head 9c380d4. Consider uploading reports for the commit 9c380d4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   98.06%   98.08%   +0.01%     
==========================================
  Files          22       22              
  Lines        2068     2088      +20     
==========================================
+ Hits         2028     2048      +20     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfairh johnfairh merged commit 782cee1 into main Apr 23, 2024
6 checks passed
@johnfairh johnfairh deleted the xcconfig branch April 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant