Even more stricter rules via phpstan/phpstan-strict-rules, thecodingm…

…achind, symplify

composer.json

@@ -32,7 +32,10 @@
         "laravel/pint": "1.5.*",
         "phpstan/phpstan": "^1.12",
         "phpstan/phpstan-mockery": "^1.1",
-        "phpstan/extension-installer": "^1.4"
+        "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan-strict-rules": "^1.6",
+        "thecodingmachine/phpstan-strict-rules": "^1.0",
+        "symplify/phpstan-rules": "^13.0"
     },
     "autoload": {
         "psr-4": {
@@ -71,4 +74,4 @@
             "@test:phpunit"
         ]
     }
-}
+}

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 9
+    level: max
     phpVersion: 80000
     paths:
         - src

src/Converter.php

@@ -4,7 +4,6 @@
 
 use Jimmerioles\BitcoinCurrencyConverter\Provider\CoinbaseProvider;
 use Jimmerioles\BitcoinCurrencyConverter\Provider\ProviderInterface;
-use Jimmerioles\BitcoinCurrencyConverter\Exception\InvalidArgumentException;
 
 class Converter
 {
@@ -46,18 +45,9 @@ protected function getRate($currencyCode)
 
     /**
      * Compute currency value.
-     *
-     * @param  float $btcAmount
-     * @param  float $rate
-     * @return float
-     * @throws InvalidArgumentException
      */
-    protected function computeCurrencyValue($btcAmount, $rate): int|float
+    protected function computeCurrencyValue(int|float $btcAmount, int|float $rate): int|float
     {
-        if (! is_numeric($btcAmount)) {
-            throw new InvalidArgumentException("Argument \$btcAmount should be numeric, '{$btcAmount}' given.");
-        }
-
         return $btcAmount * $rate;
     }
 
@@ -86,18 +76,9 @@ public function toBtc(float $amount, string $currencyCode): float
 
     /**
      * Compute Bitcoin value.
-     *
-     * @param  float $amount
-     * @param  float $rate
-     * @return float
-     * @throws InvalidArgumentException
      */
-    protected function computeBtcValue($amount, $rate): int|float
+    protected function computeBtcValue(int|float $amount, int|float $rate): int|float
     {
-        if (! is_numeric($amount)) {
-            throw new InvalidArgumentException("Argument \$amount should be numeric, '{$amount}' given.");
-        }
-
         return $amount / $rate;
     }
 }

src/Provider/AbstractProvider.php

@@ -27,7 +27,7 @@ abstract class AbstractProvider implements ProviderInterface
      *
      * @var array<string, int|float>
      */
-    protected $exchangeRates;
+    protected $exchangeRates = [];
 
     /**
      * Cache key string.
@@ -83,7 +83,7 @@ public function getRate($currencyCode)
      */
     protected function isSupportedByProvider($currencyCode)
     {
-        return in_array(strtoupper($currencyCode), array_keys($this->exchangeRates));
+        return in_array(strtoupper($currencyCode), array_keys($this->exchangeRates), true);
     }
 
     /**
@@ -93,7 +93,7 @@ protected function isSupportedByProvider($currencyCode)
      */
     protected function getExchangeRates()
     {
-        if (empty($this->exchangeRates)) {
+        if ($this->exchangeRates === []) {
             $this->setExchangeRates($this->retrieveExchangeRates());
         }
 

src/Util/CurrencyCodeChecker.php

@@ -318,7 +318,7 @@ class CurrencyCodeChecker
      */
     public function isCryptoCurrency($currencyCode): bool
     {
-        return in_array(strtoupper($currencyCode), $this->cryptoCurrencyCodes);
+        return in_array(strtoupper($currencyCode), $this->cryptoCurrencyCodes, true);
     }
 
     /**
@@ -328,7 +328,7 @@ public function isCryptoCurrency($currencyCode): bool
      */
     public function isFiatCurrency($currencyCode): bool
     {
-        return in_array(strtoupper($currencyCode), $this->fiatCurrencyCodes);
+        return in_array(strtoupper($currencyCode), $this->fiatCurrencyCodes, true);
     }
 
     /**