Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune JFrog Advanced Security on this project #2299

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 9, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

  • Add jfrog-apps-config.yml
  • Add jfrog-ignore on false positive lines

@yahavi yahavi added the ignore for release Automatically generated release notes label Nov 9, 2023
@yahavi yahavi requested a review from eyalbe4 November 9, 2023 06:10
@yahavi yahavi self-assigned this Nov 9, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 9, 2023
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is probably unrelated to these changes, let's merge after making the Xray tests green.

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 9, 2023
@yahavi
Copy link
Member Author

yahavi commented Nov 9, 2023

Although this is probably unrelated to these changes, let's merge after making the Xray tests green.

This is actually related. I pushed another commit to fix the test.

@yahavi yahavi merged commit 7243c45 into jfrog:dev Nov 9, 2023
59 of 66 checks passed
@yahavi yahavi deleted the tune-jas branch November 9, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants