Fix npm scripts tests #2285
Merged
Fix npm scripts tests #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
approved these changes
Oct 25, 2023
yahavi
force-pushed
the
fix-npm-scripts
branch
from
8a35b35 to
0d62e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....When you update the JFrog CLI version in the package.json and package-lock.json files just before the release, you might encounter the following error in Scripts Tests:
Example - https://github.com/jfrog/jfrog-cli/actions/runs/6615539545/job/17967922834
To address this problem, this PR resolves it by downloading the latest released JFrog CLI version during the test.