Skip to content

Commit

Permalink
PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
Or-Geva committed Oct 17, 2023
1 parent 1482c02 commit 6e1cffc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
14 changes: 1 addition & 13 deletions .github/workflows/analysis.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,6 @@
name: "Static Analysis"
on: [push, pull_request]
jobs:
Go-Lint:
name: Lint
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: 1.20.x
- name: Run Go vet
run: go vet -v ./...
Static-Check:
name: Static Check
runs-on: ubuntu-latest
Expand All @@ -27,7 +15,7 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
args: |
--timeout 5m --out-${NO_FUTURE}format colored-line-number --enable errcheck,gosimple,govet,ineffassign,staticcheck,typecheck,unused,gocritic,asasalint,asciicheck,errchkjson,exportloopref,forcetypeassert,makezero,nilerr,unparam,unconvert,wastedassign,usestdlibvars
--timeout 5m --out-${NO_FUTURE}format colored-line-number --enable errcheck,gosimple,govet,ineffassign,staticcheck,typecheck,unused,gocritic,asasalint,asciicheck,errchkjson,exportloopref,forcetypeassert,makezero,nilerr,unparam,unconvert,wastedassign,usestdlibvars
Go-Sec:
name: Go-Sec
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ func TestErroneousGoMod(t *testing.T) {
}

func TestMinGoVersionGoMod(t *testing.T) {
_, errs := parseGoMod(filepath.Join("testdata", "version","minor", "go.mod"))
_, errs := parseGoMod(filepath.Join("testdata", "version", "minor", "go.mod"))
assert.Nil(t, errs)
}

func TestMinGoVersionWithPatchGoMod(t *testing.T) {
_, errs := parseGoMod(filepath.Join("testdata", "version","patch", "go.mod"))
_, errs := parseGoMod(filepath.Join("testdata", "version", "patch", "go.mod"))
assert.Nil(t, errs)
}

Expand Down

0 comments on commit 6e1cffc

Please sign in to comment.