Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: move informative stuff out of the list of actions in the release process #621

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented Nov 14, 2024

I'm always tripping over this: It looks like another action, but isn't. It's an information instead. I propose to move the information to a note and reformulate this item as an action instead:

Before

2. A GitHub action will see the new tag and do the following:
   - Build and publish the container image at `quay.io/jetstack/venafi-agent`,
   - Build and publish the Helm chart at `oci://quay.io/jetstack/charts/venafi-kubernetes-agent`,
   - Create a draft GitHub release,
   - Upload the Helm chart tarball to the GitHub release.

After

2. Wait until the GitHub Actions finishes.

@maelvls maelvls marked this pull request as ready for review November 15, 2024 13:16
@maelvls maelvls requested a review from wallrj November 21, 2024 10:15
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@@ -94,17 +94,21 @@ The release process is semi-automated.

### Step 1: Git Tag and GitHub Release

> [!NOTE]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about [!NOTE]. Thanks @maelvls 😄

@maelvls maelvls merged commit a9cdc3f into master Nov 25, 2024
2 checks passed
@maelvls maelvls deleted the release-process-update branch November 25, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants