Allow specification of client_id by env var #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying client_id by env var allows us to pre-populate a namespace
with all the relevant authentication details.
Currently, we have to populate a secret with a private key, and then
create a deployment given the client id. Specifying via an env var would
allow us to create/rotate deployments and credentials independently of each
other.
e.g.
```
env:
- name: CLIENT_ID
valueFrom:
configMapKeyRef:
name: venafi-agent-svc-account
key: client_id
```
Signed-off-by: Adrian Lai <adrian.lai@jetstack.io>
|
Forgot I could just push to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying client_id by env var allows us to pre-populate a namespace with all the relevant authentication details.
Currently, we have to populate a secret with a private key, and then create a deployment given the client id. Specifying via an env var would allow us to create/rotate deployments and credentials independently of each other.
e.g.