VC-36545: Collect the secret's labels #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a mistake I made in the indexing, the "case 1" was only checking that all the remaining chars in the last line but the last char was made of indentation: in the example in the commit title, it was looking at "\t\t" rather than "\t\t}", thus wrongly going in the "case 1".
maelvls
changed the title
maelvls
commented
Oct 3, 2024
tfadeyi
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: VC-36545
This PR makes sure labels are being pushed for Secret resources.
Note to the reviewer: I took the liberty of rewriting the tests. The best approach would have been to write a minimal commit with the feature and test changes, and then refactor the tests... but since Olu would prefer this being shipped as part of 1.1.0, I chose not to bother trying to separate the changes from the test refactoring.
Tests
The unit tests cover the changes, so I haven't proceeded with manual e2e tests.