Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify path in proto.mk to fix jeremyje/coretemp-exporter#90 #91

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

nukopal
Copy link
Contributor

@nukopal nukopal commented Feb 19, 2024

Hi @jeremyje ,
This pull request addresses the #90, where the Makefile paths were not updating correctly with changes to dependencies. I have modified the Makefile to ensure that the paths are updated appropriately.

Applying this change, the build for all targets finished successfully. I have attached the log here.
build_2024-02-20_01-11-00.log

If there are any problems, please feel free to correct them.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d3e671) 36.32% compared to head (6662026) 36.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   36.32%   36.32%           
=======================================
  Files          15       15           
  Lines         534      534           
=======================================
  Hits          194      194           
  Misses        320      320           
  Partials       20       20           
Flag Coverage Δ
unittests 36.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremyje jeremyje merged commit 297055a into jeremyje:main Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants