Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Changelog and bump version to 1.15.0 #568

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Nov 12, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #568 (02c92eb) into master (c086b7f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 02c92eb differs from pull request most recent head ef9566f. Consider uploading reports for the commit ef9566f to get more accurate results

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   87.63%   87.71%   +0.08%     
==========================================
  Files          65       65              
  Lines        2862     2889      +27     
  Branches      261      198      -63     
==========================================
+ Hits         2508     2534      +26     
  Misses        337      337              
- Partials       17       18       +1     
Impacted Files Coverage Δ
tests/test_views_login.py 100.00% <100.00%> (ø)
tests/test_views_setup.py 100.00% <100.00%> (ø)
two_factor/views/core.py 96.10% <100.00%> (-0.19%) ⬇️
two_factor/views/mixins.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@claudep claudep mentioned this pull request Dec 3, 2022
6 tasks
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@claudep
Copy link
Contributor Author

claudep commented Dec 17, 2022

@jaap3, may I ask you to approve the PR, if not already done, so as I can push to master?

@claudep
Copy link
Contributor Author

claudep commented Dec 18, 2022

Thanks, but seemingly not sufficient for pushing, probably because you are not Jazzband member?

@pickfire
Copy link
Contributor

pickfire commented Jan 6, 2023

@moggers87 sorry for the ping but I wonder if we can have a version bump?

@matthewhegarty
Copy link

+1 for a version bump please 🙏 , currently blocked from upgrading to django 4.1 due to #512.

@pickfire
Copy link
Contributor

IIRC I tested the latest git commit and have some issues with migrations, but I don't recall what was it, so I didn't use the git version either.

@matthewhegarty
Copy link

If it helps, I just tried a build of my app which includes django-two-factor-auth master. I can see there is a new migration (0008_delete_phonedevice.py). This migration applied ok.

All my tests passed (including with upgrade to django 4.1), and my application code (including 2FA) seems to be working correctly. So from my testing this release is ok.

@claudep
Copy link
Contributor Author

claudep commented Jan 12, 2023

This PR is still missing an approval by a Jazzband member.

@moggers87
Copy link
Collaborator

The Python 3.11 build is failing for some reason, though I can't see why.

@moggers87
Copy link
Collaborator

I was looking in the wrong place:

 ======================================================================
  Error: ERROR: test_webauthn_attestation_and_assertion (two_factor.plugins.webauthn.tests.test_e2e.E2ETests.test_webauthn_attestation_and_assertion)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/django-two-factor-auth/django-two-factor-auth/./two_factor/plugins/webauthn/tests/test_e2e.py", line 96, in test_webauthn_attestation_and_assertion
      self.register_authenticator()
    File "/home/runner/work/django-two-factor-auth/django-two-factor-auth/./two_factor/plugins/webauthn/tests/test_e2e.py", line 82, in register_authenticator
      self.wait_for_url(urljoin(self.base_url, reverse("two_factor:setup")))
    File "/home/runner/work/django-two-factor-auth/django-two-factor-auth/./two_factor/plugins/webauthn/tests/test_e2e.py", line 65, in wait_for_url
      WebDriverWait(self.webdriver, self.timeout).until(EC.url_to_be(url))
    File "/home/runner/work/django-two-factor-auth/django-two-factor-auth/.tox/py311-dj32-webauthn/lib/python3.11/site-packages/selenium/webdriver/support/wait.py", line 90, in until
      raise TimeoutException(message, screen, stacktrace)
  selenium.common.exceptions.TimeoutException: Message: 

Not sure why this is happening now though as it seems #567 was fine

@moggers87
Copy link
Collaborator

@claudep I made a separate PR to fix the webauthn tests: #582

Copy link
Collaborator

@moggers87 moggers87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudep claudep merged commit 74221c0 into jazzband:master Jan 18, 2023
@claudep claudep deleted the release115 branch January 18, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants