Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove public modifier from interfaces #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove public modifier from interfaces #172

wants to merge 1 commit into from

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Feb 16, 2023

Methods in interfaces are public by default.

elharo
elharo reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember in which version of Java this became possible? I feel like we used to have to add public but that was a long time ago.

@hduelme
Copy link
Contributor Author

hduelme commented Feb 16, 2023

I don't remember. If it was the case, it has to be before Java 1.3.

@hduelme
Copy link
Contributor Author

hduelme commented Jun 8, 2023

@elharo is there anything else to do here?

@elharo
Copy link
Contributor

elharo commented Jun 8, 2023

No, I just need to decide whether I want to merge this or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hduelme @elharo