-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column type conversions #38
base: master
Are you sure you want to change the base?
Conversation
@@ -19,6 +19,9 @@ Imports: | |||
stringi, | |||
stringr, | |||
testthat (>= 3.0.3), | |||
vdiffr (>= 1.0.2) | |||
vdiffr (>= 1.0.2), | |||
jaspBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Originally, the idea was that jaspTools
could do things, like installing jaspBase
, for a developer. But this kinda looks like it becomes a cycle. Or is this intended as a workaround until we get rid of jaspTools altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even though we already had things like jaspBase:::.vdf
before, this change will make it impossible to install jaspTools
without first installing jaspBase
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not necessary, but since we are using jaspBase
anyway I figured it might as well be specified as a dependency - hence I asked before whether it's deliberate that it's excluded.
So I guess I am saying I can remove it - as you say jaspTools
sets up jaspBase
anyway so it's not a gib deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops sorry I missed that in your message.
I'll update the R version for the unit tests, hashtab was introduced later. |
@Kucharssim can you rebase/ retrigger the tests? If I rerun them they still use the old R version. |
Goes in tandem with: jasp-stats/jaspBase#136
Instead of relying on rbridge finding the
readDatasetToEndNative
in jaspTools, we just rely on the new data set functionality injaspBase
. I added jaspBase as a dependency explicitly now (even though we used to call it from jaspTools before as well) - or is there a reason for not doing it?