Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add gitignore, pr template - DO NOT MERGE #38

Closed

Conversation

jeshernandez
Copy link
Contributor

Testing feature to main PR. Are we using github runners? Example runs-on: [ubuntu-latest]

  1. Adding PR template.
  2. Adding .gitignore
  3. Adding yaml linting (opening the door for C++ linting)

Copy link
Contributor

github-actions bot commented Jan 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeshernandez
Copy link
Contributor Author

Trying to figure out how ben's comment did generate the json entry in signatures. I may take a stab at it later.

@jeshernandez
Copy link
Contributor Author

Seems to be some type of cla-bot issue, could be permissions? Not automating/picking up the comments from the signed CLA?

@jamespilgrim
Copy link
Owner

I'm trying to figure out the CLA issue so I can push these into the repo.

Could you try adding the "I have read the CLA Document and I hereby sign the CLA" again as a comment in this Issue #38 ?

Also, I wasn't aware of github "runners". How cool!

@jamespilgrim
Copy link
Owner

Oh - hey - is it possible you're adding a comment directly to the gist, instead of here as a comment in the issue? I think it has to be the latter.

@benhalpern
Copy link
Contributor

This partially addresses #41 — can be closed once non-PR issues also get a template (or if it's determined not to be the right thing for the repo 🙂)

@jamespilgrim
Copy link
Owner

Hi there - Just wanted to remind you to try the CLA process again (see comments above). Thank you!

@jeshernandez
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jeshernandez
Copy link
Contributor Author

Looks like there may have been a permissions issue. https://github.com/jamespilgrim/PiTrac/actions/runs/12637411892/job/35211538806 I also noticed you're requiring signed commits too. I'll configure that as well.

@jeshernandez jeshernandez force-pushed the feature/add-gitignore branch 2 times, most recently from 5a6087c to 11a4461 Compare January 6, 2025 18:12
@jeshernandez jeshernandez force-pushed the feature/add-gitignore branch from 11a4461 to ce312b3 Compare January 6, 2025 18:16
@jeshernandez jeshernandez changed the title Feature/add gitignore, pr template Feature/add gitignore, pr template - DO NOT MERGE Jan 6, 2025
@jeshernandez
Copy link
Contributor Author

Closing due to additional changes being introduced.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants