-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutov / #2426 create interface to upload excel data #2467
Draft
MarianS23
wants to merge
40
commits into
develop
Choose a base branch
from
#2426_Create_interfase_to_upload_Excel_data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarianS23
commented
Apr 11, 2024
•
edited
Loading
edited
MarianS23
changed the title
#2426 create interfase to upload excel data
#2426 create interface to upload excel data
Apr 11, 2024
MarianS23
changed the title
#2426 create interface to upload excel data
Shutov / #2426 create interface to upload excel data
May 23, 2024
humanmantis
requested changes
Jun 11, 2024
src/app/shared/services/admin-import-export/admin-import-export.service.ts
Outdated
Show resolved
Hide resolved
src/app/shared/services/admin-import-export/admin-import-export.service.spec.ts
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/export-providers/export-providers.component.html
Outdated
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.ts
Outdated
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.ts
Outdated
Show resolved
Hide resolved
...app/shell/admin-tools/data/import-export/import-providers/import-providers.component.spec.ts
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.ts
Outdated
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.ts
Outdated
Show resolved
Hide resolved
humanmantis
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general note for unit tests - divide the test into arrange/act/assert blocks to improve readability.
See how the tests for app.component look like
src/app/shared/services/admin-import-export/admin-import-export.service.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/services/admin-import-export/import-validation/import-validation.service.spec.ts
Show resolved
Hide resolved
src/app/shared/services/admin-import-export/import-validation/import-validation.service.spec.ts
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.html
Outdated
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.scss
Outdated
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.scss
Outdated
Show resolved
Hide resolved
...app/shell/admin-tools/data/import-export/import-providers/import-providers.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shell/admin-tools/data/import-export/import-providers/import-providers.component.ts
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.