Draft workshop management #1602
Conversation
IrynaNakoneshniuk
force-pushed
the
draft-workshop-management
branch
from
dbe21bd to
32fae6e
Compare
AndriyYehorov
force-pushed
the
draft-workshop-management
branch
from
086d918 to
4ecca8f
Compare
| public class DateTimeRangeDraftDto | ||
| { | ||
| [JsonConverter(typeof(TimespanConverter))] | ||
| public TimeSpan StartTime { get; set; } |
There was a problem hiding this comment.
Could you check if TimeOnly is relevant type here?
(My main concern against TimeSpan is possibility t have such value as TimeSpan.FromDays(3) i.e., that means nothing for Start/EndTime, I guess)
There was a problem hiding this comment.
@VadymLevkovskyi Could you please clarify your question?
There was a problem hiding this comment.
I'm assuming that DateTimeRangeDraftDto.StartTime field has next range of allowed values: 00:00:00...23:59:59.999. If my assumption is correct - then valid for TimeSpan value (i.e. TimeSpan.FromDays(3)) is not valid from business perspective and thus wrong type is chosen - instead of TimeSpan there should be i.e. TimeOnly. So I've asked @IrynaNakoneshniuk to check if mentioned type is more relevant.
There was a problem hiding this comment.
Btw, if my assumption is wrong and StartTime could have not only time part but also date part, then property name should be fixed
There was a problem hiding this comment.
@VadymLevkovskyi Replaced TimeSpan with TimeOnly
| public TimeSpan EndTime { get; set; } | ||
|
|
||
| [Required] | ||
| public List<DaysBitMask> Workdays { get; set; } |
There was a problem hiding this comment.
Please ensure that DaysBitMask is not sufficient here.
I'm in doubt of List, b/c it makes possible to have 2 Wednesdays i.e.
There was a problem hiding this comment.
All duplicate Workdays will be removed during the mapping to the database entity when a workshop is created/updated.
There was a problem hiding this comment.
That's cool, that they are sanitized somewhere. But my main question is why we have to have to use the wrong type?
… entity in parallel operations.
AndriyYehorov
force-pushed
the
draft-workshop-management
branch
from
b790b63 to
d4d2ca6
Compare
|
Summary of Changes:
TrackableBaseEntity:Introduced a reusable base model for non-business entities to track changes such as CreatedBy, ModifiedBy, CreatedAt, and
ModifiedAt.
WorkshopDraft andTeacherDraftintroduced models to store draft data for workshops and teachersIWorkshopDraftRepository, added methodsUpdateandDeleteto ensure data consistency during concurrent access.EntityDeletedConflictExceptionandEntityModifiedConflictExceptionCreatemethod toIWorkshopDraftService