Tsylia/Admins Template pattern #1328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses to WebApi. This is an attempt to refactor these classes according to the Template method.
…ights from controller to services. GetByFilter still doesn't work.
andriitsylia
force-pushed
the
Tsylia/AdminsTemplatePattern
branch
from
881081a to
cf5a881
Compare
…ryAdminEdit to MinistryAdmin. Add migration AddChangeBlockPermissionForAdmins.
…mission attributes. Add migration.
|
andriitsylia
added
enhancement
|
@VadymLevkovskyi, could you review this PR? It attempts to use the Template pattern to organize the admins' services in the WebAPI project. I've left the old services to compare their functionality. I will remove them, rename new ones, and start to write tests when this code improves after your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has added new admins's dtos, services, controllers, and utility classes to WebApi. This is an attempt to refactor these classes according to the Template method.