Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go.mod): depend on go1.22 #38

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(go.mod): depend on go1.22 #38

merged 1 commit into from
Jan 13, 2025

Conversation

lidel
Copy link
Contributor

@lidel lidel commented Jan 13, 2025

Depend on 1.22.0 to match last go-libp2p release.
This solves problem described in libp2p/go-libp2p#3103 (comment)

Goal of this PR is to close #37 and maximize interop with existing go-libp2p code (we don't want p2p-forge and autotls to cause issues with deps when people want to add it to existing code).

@lidel lidel force-pushed the chore/interop-with-go1.22 branch from f4e63e5 to 144283f Compare January 13, 2025 21:16
@lidel lidel marked this pull request as ready for review January 13, 2025 21:28
@@ -21,7 +22,7 @@ require (
github.com/multiformats/go-multiaddr-dns v0.4.1
github.com/multiformats/go-multibase v0.2.0
github.com/prometheus/client_golang v1.20.5
github.com/slok/go-http-metrics v0.13.0
github.com/slok/go-http-metrics v0.12.0
Copy link
Contributor Author

@lidel lidel Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary to as 0.13 depends on go.1.23.

@lidel lidel changed the title fix: depend on go1.22 fix(go.mod): depend on go1.22 Jan 13, 2025
@lidel lidel merged commit f422006 into main Jan 13, 2025
4 checks passed
@lidel lidel deleted the chore/interop-with-go1.22 branch January 13, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go version in go.mod should match go-libp2p
1 participant