Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go version in go.mod should match go-libp2p #37

Closed
lidel opened this issue Jan 13, 2025 · 0 comments · Fixed by #38
Closed

Go version in go.mod should match go-libp2p #37

lidel opened this issue Jan 13, 2025 · 0 comments · Fixed by #38
Labels
bug Something isn't working

Comments

@lidel
Copy link
Contributor

lidel commented Jan 13, 2025

Ref. libp2p/go-libp2p#3103 (comment)

p2p-forge/client should not force upgrade.
We should follow the same go version as go.mod from go-libp2p.
@lidel lidel added the bug Something isn't working label Jan 13, 2025
@lidel lidel changed the title Lower go requirement to 1.22 Go versuon in go.mod should match go-libp2p Jan 13, 2025
@lidel lidel mentioned this issue Jan 13, 2025
Open
2 tasks
@lidel lidel changed the title Go versuon in go.mod should match go-libp2p Go version in go.mod should match go-libp2p Jan 13, 2025
lidel added a commit that referenced this issue Jan 13, 2025
@lidel
fix: depend on go1.22
f4e63e5 
Close #37
@lidel lidel mentioned this issue Jan 13, 2025
Merged
lidel added a commit that referenced this issue Jan 13, 2025
@lidel
fix: depend on go1.22
144283f 
Close #37
@lidel lidel closed this as completed in f422006 Jan 13, 2025
@lidel lidel closed this as completed in #38 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(go.mod): depend on go1.22 ipshipyard/p2p-forge
1 participant
@lidel