feat: make env optional, prompt when not set #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| name := util.GetenvPrompt("GITHUB_USER_NAME") | ||
| email := util.GetenvPrompt("GITHUB_USER_EMAIL") | ||
| token := util.GetenvPromptSecret("GITHUB_TOKEN", "The token should have the following scopes: ... Please enter the token:") |
There was a problem hiding this comment.
Yeap, I didn't check what those should be exactly yet.
| return fmt.Errorf("GITHUB_TOKEN not set") | ||
| } | ||
| name := util.GetenvPrompt("GITHUB_USER_NAME") | ||
| email := util.GetenvPrompt("GITHUB_USER_EMAIL") |
There was a problem hiding this comment.
Should / could we keep the default?
Something like
> GITHUB_USER_EMAIL is not set. Please enter a value (default to "noreply+kuboreleaser@ipfs.tech")
> ?
There was a problem hiding this comment.
I was thinking that the default might be a bit misleading. As in, if the user is using kuboreleaser, the commits should be associated with the user. If it's CI (hopefully, in the near future), then we can make sure the env var is set. Does it make sense?
Co-authored-by: Laurent Senta <Laurent.Senta@gmail.com>
hacdias
approved these changes
Sep 25, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback from #17. It:
.envfile optional (when a specific secret is not available, the tool will prompt for user input instead of quitting)