[uss_qualifier] netrid - NET0320: check SP behavior upon UAS disconnection #880
+885
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
changed the title
Shastick
force-pushed
the
net0320-uas-disconnect
branch
from
f11490e to
ba2fc64
Compare
Shastick
force-pushed
the
net0320-uas-disconnect
branch
from
ba2fc64 to
c3e6ae2
Compare
…try is reported as such
Shastick
force-pushed
the
net0320-uas-disconnect
branch
from
c3e6ae2 to
644210a
Compare
barroco
reviewed
Jan 16, 2025
|
|
||
| ### Service Provider polling test step | ||
|
|
||
| If a DSS was provided to this test scenario, uss_qualifier acts as a Display Provider to query Service Providers under test in this step. |
There was a problem hiding this comment.
For this particular scenario, the DSS is mandatory, right?
There was a problem hiding this comment.
Would it make sense to move some of the documented checks to fragments since they are the same as for the nominal one?
| @@ -88,6 +88,23 @@ def get_test_flights(self) -> List[TestFlight]: | |||
|
|
|||
| return test_flights | |||
|
|
|||
| def truncate_flights_duration(self, duration: timedelta): | |||
There was a problem hiding this comment.
Is it possible that using this approach (altering in place objects) we are actually impacting other scenarios which may reference the root object upstream ?
| This evaluator observes a set of provided RIDSystemObservers in | ||
| evaluate_system by repeatedly polling them according to the expected data | ||
| provided to RIDObservationEvaluator upon construction. During these | ||
| evaluations, RIDObservationEvaluator mutates provided findings object to add |
There was a problem hiding this comment.
Suggested change
| evaluations, RIDObservationEvaluator mutates provided findings object to add | |
| evaluations, DisconnectedUASObservationEvaluator mutates provided findings object to add |
|
|
||
| This evaluator observes a set of provided RIDSystemObservers in | ||
| evaluate_system by repeatedly polling them according to the expected data | ||
| provided to RIDObservationEvaluator upon construction. During these |
There was a problem hiding this comment.
Suggested change
| provided to RIDObservationEvaluator upon construction. During these | |
| provided to DisconnectedUASObservationEvaluator upon construction. During these |
|
|
||
| # Keep track of the flights that we have observed as having been 'disconnected' | ||
| # (last observed telemetry corresponds to last injected one within the window where data is returned) | ||
| self._witnessed_disconnections: Set[str] = set() |
There was a problem hiding this comment.
For consistency:
Suggested change
| self._witnessed_disconnections: Set[str] = set() | |
| self._observed_disconnections: Set[str] = set() |
| ) -> bool: | ||
| """ | ||
| Polls service providers relevant to the injected test flights and verifies that, | ||
| for any flight that is not sending telemtry data anymore (ie, the last injected telemetry data lies in the past), |
There was a problem hiding this comment.
Suggested change
| for any flight that is not sending telemtry data anymore (ie, the last injected telemetry data lies in the past), | |
| for any flight that is not sending telemetry data anymore (ie, the last injected telemetry data lies in the past), |
| ].observed_flight.flight.timestamp.datetime | ||
| ) | ||
|
|
||
| if arrow.get(last_expected_telemetry) != arrow.get( |
There was a problem hiding this comment.
I would expect that both values may not be completely matching and some error / inaccuracy should be allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scenario to cover NET0320: service providers that cease receiving telemetry data for a flight must return the last returned telemetry (position and timestamp, notably) during the near real-time window (60 seconds).
This is achieved by:
DisconnectedUASObservationEvaluator)FlightDataResource(this is not strictly required but ensures that scenarios don't needlessly run too long)