Created artist synonym generator and artist list files #305
Conversation
There was a problem hiding this comment.
good :)
there are few things should be fixed.
and I got an error:
./artist-synonyms-generator.sh: line 63: : No such file or directory
any ideas why?
And please try to run it locally as well, to check that everything works fine.
Be sure you have excluded csv files from repository ;)
bin/artist-synonyms-generator.sh
Outdated
| trap "kill $!" EXIT #Die with parent if we die prematurely | ||
|
|
||
| #Overwrite current synonym files if they exist | ||
| echo -n > alexa-artist-list-with-synonyms.csv |
There was a problem hiding this comment.
it seems we should add both of csv files to gitignore
bin/artist-synonyms-generator.sh
Outdated
| #While loop to read through each line of artists list | ||
| while IFS='' read -r line || [[ -n "$line" ]]; do | ||
| name="$line" | ||
| echo -n $name"," >> alexa-artist-list-with-synonyms.csv |
There was a problem hiding this comment.
it seems you combing here spaces and tabs. Please use spaces only
bin/artist-synonyms-generator.sh
Outdated
| echo -n $name | sed 's/and.*//'>> google-artist-list-with-synonyms.csv | ||
| echo -n "\"">> google-artist-list-with-synonyms.csv | ||
| fi | ||
| if [[ $name == "The"* ]]; then |
There was a problem hiding this comment.
It seems could catch words like Therapy, Thelda, theft and etc. We don't have such artists now, but we would be able have them later
| @@ -0,0 +1,67 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
please changes this file to executable:
chmod +x bin/artist-synonyms-generator.sh
|
I have generated Alexa and Google cvs and found that synonyms have an extra new line. |
|
as well I have tried to upload entities to Google Action (draf copy) and got error: once I have renamed file I got: as well we may want add step to README which would describe what should be done to get desired result |
|
@adaveinthelife thanks for the improvement, it looks much better. I only found some extra commas ( |
.gitignore
Outdated
| @@ -8,4 +8,5 @@ node_modules | |||
| functions/firebase-debug.log | |||
| npm-debug.log | |||
| .DS_Store | |||
|
|
|||
| bin/alexa-artist-list-with-synonyms.csv | |||
There was a problem hiding this comment.
pls update the name of excluded files to the new ones
|
@adaveinthelife as well Alexa Skill fails on a new list of entities in particular for artist |
|
Still doing more testing on this but I've realized something that may cause us an issue. So as it currently stands - many of the names have parenthesis and square brackets in their names. This is a problem because the system will not allow you do raw bulk entry with these chars in the name (either in artist name or synonyms). Most likely because the system would have no way of matching these artists because the special chars would never be translated to dialog. If I write a rule to remove these, will it break the music pipeline? |
I wrote this script to address the issue #302 which requested a script be created to generate CSV files for the Assistant and Alexa that would contain synonyms for artist titles.
To run this script, you would type
artists-synonym-generator artists.txtThe
artists.txtfile contains a list of current artists that we have in the collections.