Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align structures for 64-bit platforms (optimization move and copy object cost time) #786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Align structures for 64-bit platforms (optimization move and copy object cost time) #786

wants to merge 1 commit into from

Conversation

GermanAizek
Copy link
Contributor

@GermanAizek GermanAizek commented Dec 19, 2024 •
edited
Loading

@MichalMrozek,

  • InlineSamplerBaseT 16 -> 12 bytes
  • CsrSelectionArgs 88 -> 80 bytes
  • EngineInfo 64 -> 48 bytes
  • FragmentStorage 48 -> 40 bytes
  • SvmFreeUserData 40 -> 32 bytes
  • PayloadArgumentBaseT 40 -> 36 bytes
  • ImageDescriptor 72 -> 64 bytes
  • PerThreadMemoryBufferBaseT 16 -> 12 bytes
  • CopyEngineState 24 -> 16 bytes
  • BatchBuffer 120 -> 112 bytes
  • DebugMetadata 32 -> 24 bytes
  • ImmediateFlushData 48 -> 40 bytes

@GermanAizek GermanAizek force-pushed the align-structures-for-64bit branch from 840c942 to 363997d Compare December 31, 2024 15:50
JablonskiMateusz
JablonskiMateusz reviewed Jan 3, 2025
View reviewed changes
opencl/extensions/public/cl_gl_private_intel_structures.h Outdated
@@ -48,15 +48,15 @@ typedef struct _tagGLCLResourceInfo {
} GL_CL_RESOURCE_INFO, *PGL_CL_RESOURCE_INFO;

typedef struct _tagCLGLBufferInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is struct shared with GL, we have it in a form that GL is expressing. This cannot be optimized

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is struct shared with GL, we have it in a form that GL is expressing. This cannot be optimized

fixed it 67c2077

@GermanAizek
performance: align structures for 64-bit platforms
67c2077 
Signed-off-by: Semenov Herman (Семенов Герман) <GermanAizek@yandex.ru>
@GermanAizek GermanAizek force-pushed the align-structures-for-64bit branch from 363997d to 67c2077 Compare January 4, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JablonskiMateusz JablonskiMateusz JablonskiMateusz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GermanAizek @JablonskiMateusz