-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to std::make_unique C++17 (more safe) in all scope project #785
base: master
Are you sure you want to change the base?
Conversation
@GermanAizek please short the link in commit msg, not to exceed 80 characters in commit msg line |
7b1272e
to
5fdb97a
Compare
Fix it 5fdb97a |
Now, since we have 2025 please update year in copyright header in modified files |
Signed-off-by: Semenov Herman (Семенов Герман) <GermanAizek@yandex.ru>
5fdb97a
to
87d9e25
Compare
fixed in this 87d9e25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto allocPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize); | ||
auto resPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize); | ||
auto resPrivateRuntimeData = std::make_unique<char>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto allocPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize); | |
auto resPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize); | |
auto resPrivateRuntimeData = std::make_unique<char>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize); | |
auto allocPrivateData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize); | |
auto resPrivateData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize); | |
auto resPrivateRuntimeData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize); |
@MichalMrozek,
Reference: https://stackoverflow.com/questions/22571202/differences-between-stdmake-unique-and-stdunique-ptr-with-new