Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to std::make_unique C++17 (more safe) in all scope project #785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@JablonskiMateusz
Copy link
Contributor

@GermanAizek please short the link in commit msg, not to exceed 80 characters in commit msg line
You may use short link: https://stackoverflow.com/q/22571202 or point to this PR where the link is PR description

@GermanAizek
Copy link
Contributor Author

@GermanAizek please short the link in commit msg, not to exceed 80 characters in commit msg line You may use short link: https://stackoverflow.com/q/22571202 or point to this PR where the link is PR description

Fix it 5fdb97a

@JablonskiMateusz
Copy link
Contributor

Now, since we have 2025 please update year in copyright header in modified files

Signed-off-by: Semenov Herman (Семенов Герман) <GermanAizek@yandex.ru>
@GermanAizek
Copy link
Contributor Author

Now, since we have 2025 please update year in copyright header in modified files

fixed in this 87d9e25

Copy link
Contributor

@JablonskiMateusz JablonskiMateusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change merged in 4cf685c but then reverted in 58707e0 due to functional regressions.

Comment on lines +917 to +919
auto allocPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize);
auto resPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize);
auto resPrivateRuntimeData = std::make_unique<char>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto allocPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize);
auto resPrivateData = std::make_unique<char>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize);
auto resPrivateRuntimeData = std::make_unique<char>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize);
auto allocPrivateData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.TotalPrivateDriverDataSize);
auto resPrivateData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.ResourcePrivateDriverDataSize);
auto resPrivateRuntimeData = std::make_unique<char[]>(queryResourceInfoFromNtHandle.PrivateRuntimeDataSize);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants