Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker-compose): fix typo of temporal_admin_tools_vdp #422

Merged
merged 1 commit into from
Jan 25, 2024
Merged

chore(docker-compose): fix typo of temporal_admin_tools_vdp #422

merged 1 commit into from
Jan 25, 2024

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Jan 25, 2024 •
edited
Loading

Because

  • The pipeline_backend_worker has wrong depends_on

This commit

  • change temporal_admin_tools_pipeline to temporal_admin_tools_vdp

@donch1989
Copy link
Member Author

Hi @pinglin ,
Please help review this PR. The depends_on was wrong.

pinglin
pinglin approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Absolutely my fault to change the service name back and forth, and forgot there is another dependency of it.

@pinglin pinglin merged commit 3570389 into main Jan 25, 2024
13 checks passed
@pinglin pinglin deleted the huitang/fix_typo_of_temporal_admin_tools branch January 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin pinglin approved these changes

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@Sarthak-instill Sarthak-instill Awaiting requested review from Sarthak-instill Sarthak-instill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donch1989 @pinglin @droplet-bot