chore(pipeline-backend): add artifact config for pipeline-backend #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuang8511
changed the title
|
Not sure how to set this env var in terraform. Will need to confirm if it is set already. |
…ateway chore(pipeline-backend): update config for api gateway in configmap
chuang8511
force-pushed
the
chunhao/ins-6780-pipeline-artifact-setting
branch
from
41118cc to
bc66a52
Compare
chuang8511
commented
Nov 14, 2024
| @@ -117,3 +118,6 @@ data: | |||
| rootpwd: {{ .Values.pipelineBackend.minio.rootpwd }} | |||
| bucketname: {{ .Values.pipelineBackend.minio.bucketname }} | |||
| secure: {{ .Values.pipelineBackend.minio.secure }} | |||
| apigateway: | |||
| host: {{ template "core.apiGateway" . }} | |||
| publicport: {{ template "core.apiGateway.httpPort" . }} | |||
There was a problem hiding this comment.
Need to check if the terraform has set it.
chuang8511
requested review from
donch1989,
jvallesm,
heiruwu and
Sarthak-instill
as code owners
donch1989
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit