Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle err when detect amazon linux 2 platform #744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamesDo-okta
Copy link

Description

Error below is thrown when running on amazon linux 2, which do not have lsb config at either locations listed, we need to fetch from etc/os-release
/usr/share/gems/gems/train-core-3.10.7/lib/train/platforms/detect/scanner.rb:39:in
`scan': Sorry, we are unable to detect your platform
(Train::PlatformDetectionFailed) from /usr/share/gems/gems/train-cor . . .

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@JamesDo-okta JamesDo-okta requested a review from a team as a code owner February 23, 2023 08:16
@chef-expeditor
Copy link
Contributor

Hello JamesDo-okta! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Signed-off-by: James Do <86258006+JamesDo-okta@users.noreply.github.com>
@aaronlippold
Copy link
Collaborator

We - the MITRE team - will also be supporting Amazon Linux 2 and Amazon Linux 2023 soon as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants