Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Thorsten Frommen <info@tfrommen.de>
Signed-off-by: Giuseppe Mazzapica <giuseppe.mazzapica@gmail.com>
  • Loading branch information
gmazzap and tfrommen authored Aug 29, 2024
1 parent e498d64 commit ac06ae3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/Application-flow.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The `Package` class implements the two phases above, respectively, in the two me

### Single-phase VS two-phases bootstrapping

It must be noted that **`Package::boot()`**, before proceeding with the "boot" phase, will execute the "build" phase if it hasn't been executed yet. In other words, it is not always necessary to explicitly call `Package::build()`, and many times calling `Package::build()` will suffice.
It must be noted that **`Package::boot()`**, before proceeding with the "boot" phase, will execute the "build" phase if it hasn't been executed yet. In other words, it is not always necessary to explicitly call `Package::build()`, and many times calling `Package::boot()` will suffice.

The following two code snippets are equivalent:

Expand Down
1 change: 1 addition & 0 deletions src/Package.php
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ class Package
/** @deprecated */
public const STATUS_BOOTED = self::STATUS_DONE;

// Map of status to package-specific and global hook, both optional (i..e, null).
private const STATUSES_ACTIONS_MAP = [
self::STATUS_INIT => [self::ACTION_INIT, self::ACTION_MODULARITY_INIT],
self::STATUS_INITIALIZED => [self::ACTION_INITIALIZED, null],
Expand Down

0 comments on commit ac06ae3

Please sign in to comment.