Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: opinit to v0.6.2 & cometbft & use latest ilvl #135

Merged
merged 3 commits into from
Dec 27, 2024
Merged

bump: opinit to v0.6.2 & cometbft & use latest ilvl #135

merged 3 commits into from
Dec 27, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Dec 17, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Added a new indirect dependency for EVM NFT support.
  • Dependency Updates

    • Updated various dependencies to their latest versions, improving compatibility and functionality across the application.
    • Removed support for executing cosmos operations with additional options, simplifying the interface.

@beer-1 beer-1 self-assigned this Dec 17, 2024
@beer-1 beer-1 requested a review from a team as a code owner December 17, 2024 03:35
Copy link

coderabbitai bot commented Dec 17, 2024

Walkthrough

This pull request focuses on updating dependency versions across two go.mod files and modifying method handling in the cosmosprecompile package. The changes primarily involve incrementing versions of various Cosmos-related libraries, including cosmossdk.io/api, github.com/cometbft/cometbft, and github.com/initia-labs/OPinit. Additionally, the ExtendedRun method in x/evm/precompiles/cosmos/contract.go has been simplified by removing the handling for METHOD_EXECUTE_COSMOS_WITH_OPTIONS.

Changes

File Changes
go.mod - Updated cosmossdk.io/api from v0.7.5 to v0.7.6
- Updated cosmossdk.io/x/tx from v0.13.5 to v0.13.7
- Updated github.com/cometbft/cometbft from v0.38.12 to v0.38.15
- Updated github.com/cosmos/cosmos-db from v1.0.2 to v1.1.0
- Updated github.com/cosmos/cosmos-sdk from v0.50.10 to v0.50.11
- Updated cosmossdk.io/depinject from v1.0.0 to v1.1.0
- Updated github.com/cosmos/iavl from v1.2.0 to v1.2.2
- Updated github.com/emicklei/dot from v1.6.1 to v1.6.2
- Updated google.golang.org/genproto/googleapis/rpc from v0.0.0-20240903143218-8af14fe29dc1 to v0.0.0-20240930140551-af27646dc61f
- Updated replace directive for github.com/cometbft/cometbft
integration-tests/go.mod - Updated github.com/cometbft/cometbft from v0.38.12 to v0.38.15
- Updated github.com/initia-labs/OPinit from v0.6.1 to v0.6.2
- Updated github.com/initia-labs/OPinit/api from v0.6.0 to v0.6.2
- Added indirect dependency github.com/initia-labs/kvindexer/submodules/evm-nft v0.1.6
x/evm/precompiles/cosmos/contract.go - Removed handling for METHOD_EXECUTE_COSMOS_WITH_OPTIONS in ExtendedRun method
x/evm/precompiles/cosmos/types.go - Removed constant METHOD_EXECUTE_COSMOS_WITH_OPTIONS

Possibly related PRs

Poem

🐰 Hop, hop, dependencies dance!
Versions climbing with each glance
Cosmos libraries in sync
Updating code with a rabbit's wink
Methods simplified, no more fuss,
Hopping forward, just us! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9298533 and 89ce7c5.

📒 Files selected for processing (2)
  • x/evm/precompiles/cosmos/contract.go (1 hunks)
  • x/evm/precompiles/cosmos/types.go (1 hunks)
🔇 Additional comments (2)
x/evm/precompiles/cosmos/types.go (1)

85-86: Removal of METHOD_EXECUTE_COSMOS_WITH_OPTIONS constant.

The removal of METHOD_EXECUTE_COSMOS_WITH_OPTIONS perfectly aligns with the simplification in contract.go. Verify that no other references to this constant remain throughout the repository.

✅ Verification successful

No remaining references to METHOD_EXECUTE_COSMOS_WITH_OPTIONS found

The ripgrep search returned no results, confirming that there are no remaining references to METHOD_EXECUTE_COSMOS_WITH_OPTIONS in the codebase. This validates that the constant's removal was complete and consistent.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Searches for any remaining references to METHOD_EXECUTE_COSMOS_WITH_OPTIONS
rg "METHOD_EXECUTE_COSMOS_WITH_OPTIONS"

Length of output: 39

x/evm/precompiles/cosmos/contract.go (1)

254-254: Elimination of the METHOD_EXECUTE_COSMOS_WITH_OPTIONS case.

Consolidating the logic into a single METHOD_EXECUTE_COSMOS path helps simplify call handling. Confirm that no callers invoke the removed method and that tests cover the updated flow.

✅ Verification successful

No references found to the removed METHOD_EXECUTE_COSMOS_WITH_OPTIONS method

The verification scripts found no references to METHOD_EXECUTE_COSMOS_WITH_OPTIONS across the codebase, including:

  • No constant definitions or enums
  • No usage in test files
  • No references in the contract file itself
  • No mentions in comments or documentation

This suggests the method was successfully removed and all callers have been updated to use the consolidated METHOD_EXECUTE_COSMOS path.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Ensure no references remain to the old method in tests, comments, or docstrings.
rg "execute_cosmos_with_options" -A 3 -B 3

Length of output: 42


Script:

#!/bin/bash
# Search for any references to METHOD_EXECUTE_COSMOS_WITH_OPTIONS in the codebase
rg "METHOD_EXECUTE_COSMOS_WITH_OPTIONS" -A 3 -B 3

# Search for any test files that might reference the old method
fd -e test.go -X rg "EXECUTE_COSMOS_WITH_OPTIONS" -A 3 -B 3

# Look for the method definition and its usages in the contract file
rg "EXECUTE_COSMOS_WITH_OPTIONS" x/evm/precompiles/cosmos/contract.go -A 3 -B 3

# Check for any method constants or enum definitions
ast-grep --pattern 'const METHOD_EXECUTE_COSMOS_WITH_OPTIONS = $_'

Length of output: 258


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 changed the title bump: opinit to v0.6.2 bump: opinit to v0.6.2 & cometbft & use latest ilvl Dec 26, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (f0aa106) to head (89ce7c5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   57.03%   57.03%           
=======================================
  Files         110      110           
  Lines       10049    10049           
=======================================
  Hits         5731     5731           
  Misses       3495     3495           
  Partials      823      823           
Files with missing lines Coverage Δ
x/evm/precompiles/cosmos/contract.go 52.55% <100.00%> (ø)

@beer-1 beer-1 merged commit 8730fd9 into main Dec 27, 2024
10 checks passed
@beer-1 beer-1 deleted the bump/deps branch December 27, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant