Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease cache size #46

Merged
merged 1 commit into from
Jul 1, 2024
Merged

decrease cache size #46

merged 1 commit into from
Jul 1, 2024

Conversation

Vritra4
Copy link
Collaborator

@Vritra4 Vritra4 commented Jun 30, 2024

1M cache is too big for many operators - it may consume 10G of RAM because of huge blocks
so decreasing to 100k sounds more reasonable

@Vritra4 Vritra4 requested review from SeUkKim and joon9823 June 30, 2024 05:13
@Vritra4 Vritra4 self-assigned this Jun 30, 2024
@Vritra4
Copy link
Collaborator Author

Vritra4 commented Jun 30, 2024

Actually I wanted to remove cache size: I thought it wasn't helpful because it's like upper layer cache for goleveldb's cache.
But benchmark test I’ve done proved me wrong lol
If you want to see the result - see asana.

Copy link
Collaborator

@joon9823 joon9823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit 4c3d9d4 into main Jul 1, 2024
2 checks passed
@Vritra4 Vritra4 deleted the fix/cache-size branch July 1, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants