Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Overview over consensus logic covered with tests #92

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

josef-widder
Copy link
Member

@josef-widder josef-widder commented Nov 28, 2023

  • I made a rough overview (rendered) over what consensus we cover now with quint tests.
  • Then I added two more tests for cases we didn’t cover before (line 28 and line 42 without locking).
  • For the line 28 test, I realised we didn't handle the logic about starting timeoutPrevote properly (in one case). It involved also a fix in the "pending" logic as there is a case where an incoming prevote must trigger execution of line 34 and line 36. So I fixed that in the executor.

Please have a look!

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4090cb) 95.64% compared to head (18ae857) 95.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          31       31           
  Lines        1833     1833           
=======================================
  Hits         1753     1753           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josef-widder josef-widder marked this pull request as draft November 28, 2023 17:03
@josef-widder josef-widder marked this pull request as ready for review November 30, 2023 09:48
Specs/Quint/executor.qnt Outdated Show resolved Hide resolved
@romac romac changed the title Overview over consensus logic covered with tests spec: Overview over consensus logic covered with tests Nov 30, 2023
@romac romac merged commit 1074875 into main Nov 30, 2023
10 checks passed
@romac romac deleted the josef/testcoverage branch November 30, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants