Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: add Consensus English spec #89

Merged
merged 10 commits into from
Dec 15, 2023
Merged

spec: add Consensus English spec #89

merged 10 commits into from
Dec 15, 2023

Conversation

ancazamfir
Copy link
Collaborator

Let's move and review @cason PR for the consensus English spec here

@ancazamfir ancazamfir self-assigned this Nov 27, 2023
@ancazamfir
Copy link
Collaborator Author

FYI, I will add the consensus SM diagram soon.

@ancazamfir ancazamfir changed the title spec: move Daniel's PR for the English spec to malachite spec: add Consensus English spec Nov 27, 2023
josef-widder
josef-widder reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@josef-widder josef-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Anca that we should merge messages-to-events.md and round-state-machine.md into one file.

We can add an abstract in the beginning that explains what is there and what is not there, that is, what can be found in Quint. I can do this later today.

Specs/English/messsages-to-events.md Outdated Show resolved Hide resolved
Specs/English/messsages-to-events.md Outdated Show resolved Hide resolved
@josef-widder josef-widder mentioned this pull request Dec 13, 2023
Merged
@josef-widder josef-widder self-requested a review December 15, 2023 09:13
@ancazamfir
Copy link
Collaborator Author

Thanks Josef for the updates!

@ancazamfir ancazamfir merged commit ecd0c05 into main Dec 15, 2023
1 check passed
@ancazamfir ancazamfir deleted the cason/consensus-smr branch December 15, 2023 10:48
@ancazamfir ancazamfir mentioned this pull request Jan 3, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josef-widder josef-widder josef-widder approved these changes

@romac romac Awaiting requested review from romac

Assignees

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancazamfir @josef-widder