Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle polka previous and commit quorum decisions #85

Merged
merged 16 commits into from
Nov 27, 2023

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Nov 26, 2023

Closes #77

@ancazamfir ancazamfir requested a review from romac November 26, 2023 14:36
@ancazamfir ancazamfir marked this pull request as ready for review November 27, 2023 13:39
@romac romac changed the title Add tests for polka previous and commit quorum decisions feat: Handle polka previous and commit quorum decisions Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a755b7b) 87.16% compared to head (f931aa9) 95.08%.
Report is 1 commits behind head on main.

Files Patch % Lines
Code/driver/src/driver.rs 95.45% 3 Missing ⚠️
Code/test/src/utils.rs 99.39% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   87.16%   95.08%   +7.92%     
==========================================
  Files          29       30       +1     
  Lines        1371     1728     +357     
==========================================
+ Hits         1195     1643     +448     
+ Misses        176       85      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ancazamfir ancazamfir merged commit 60cbc96 into main Nov 27, 2023
7 checks passed
@ancazamfir ancazamfir deleted the anca/driver_tests branch November 27, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Add test for receiving a proposal with a POL
2 participants