Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Align VoteKeeper spec with the code #84

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

romac
Copy link
Member

@romac romac commented Nov 24, 2023

Update the vote keeper spec to pass the current round as an argument to applyVote instead of storing the current round within the vote keeper.

This aligns the spec more closely with the implementation which will make doing MBT on the vote keeper easier.

@romac romac requested a review from josef-widder November 24, 2023 14:11
Copy link
Member

@josef-widder josef-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great. The old version of updating currentRound from the executor was not so nice. Now it seems cleaner.

@romac romac merged commit 1c3d844 into main Nov 27, 2023
2 checks passed
@romac romac deleted the romac/apply-vote-round branch November 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants