Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): Fix clippy warnings on Rust 1.84 #745

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

romac
Copy link
Member

@romac romac commented Jan 9, 2025

No description provided.

@romac romac requested a review from ancazamfir as a code owner January 9, 2025 18:22
Nightly from 2025-01-09 is currently broken and fails with an internal compiler error
@romac romac enabled auto-merge January 9, 2025 18:48
@romac romac disabled auto-merge January 9, 2025 18:48
@romac romac merged commit b3a7a67 into main Jan 9, 2025
11 checks passed
@romac romac deleted the romac/fix-clippy branch January 9, 2025 18:48
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (5c78b3e) to head (e77c098).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
code/crates/discovery/src/handlers/close.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   79.31%   79.31%   -0.00%     
==========================================
  Files         104      104              
  Lines        9024     9023       -1     
==========================================
- Hits         7157     7156       -1     
  Misses       1867     1867              
Flag Coverage Δ
integration 79.02% <90.91%> (-<0.01%) ⬇️
mbt 20.09% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant