Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose checks, id in prevote and precommit #7

Merged
merged 7 commits into from
Oct 24, 2023

Formatting and clippy

ae59ac2
Select commit
Loading
Failed to load commit list.
Merged

Propose checks, id in prevote and precommit #7

Formatting and clippy
ae59ac2
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 23, 2023 in 0s

82.59% (+11.10%) compared to 7e260c6

View this Pull Request on Codecov

82.59% (+11.10%) compared to 7e260c6

Details

Codecov Report

Merging #7 (ae59ac2) into romac/consensus (7e260c6) will increase coverage by 11.10%.
The diff coverage is 77.96%.

❗ Current head ae59ac2 differs from pull request most recent head 43d8682. Consider uploading reports for the commit 43d8682 to get more accurate results

@@                 Coverage Diff                  @@
##           romac/consensus       #7       +/-   ##
====================================================
+ Coverage            71.49%   82.59%   +11.10%     
====================================================
  Files                   15       15               
  Lines                  698      942      +244     
====================================================
+ Hits                   499      778      +279     
+ Misses                 199      164       -35     
Files Coverage Δ
Code/common/src/proposal.rs 100.00% <100.00%> (ø)
Code/common/src/validator_set.rs 96.19% <100.00%> (+3.80%) ⬆️
Code/common/src/value.rs 82.35% <100.00%> (+25.21%) ⬆️
Code/common/src/vote.rs 100.00% <100.00%> (ø)
Code/round/src/events.rs 100.00% <ø> (ø)
Code/round/src/message.rs 85.71% <100.00%> (+15.71%) ⬆️
Code/round/src/state.rs 86.54% <100.00%> (+39.48%) ⬆️
Code/vote/src/lib.rs 92.86% <ø> (ø)
Code/common/src/round.rs 82.00% <88.89%> (-6.10%) ⬇️
Code/vote/src/count.rs 90.24% <53.33%> (-5.45%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more