Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): Add example app using channels #686

Merged
merged 21 commits into from
Dec 17, 2024
Merged

feat(example): Add example app using channels #686

merged 21 commits into from
Dec 17, 2024

Conversation

greg-szabo
Copy link
Member

Closes: #XXX

This is a simplified example application in the examples/channel folder. It's using the test crate's implementation where possible.

Things that have been done:

  • fixes in app-channel (especially providing contact to the gossip-consensus actor through a channel)
  • Node implementation for the example-channel app
  • A simple state implementation for example-channel so it can store values.

There are a few bugs and features to fix/implement:

  • The code was able to produce blocks but now it doesn't: most probably the nodes don't receive the proposer's value and prevote nil. Fix my refactor bug...
  • Implement the value differently. The test crate holds a single u64 and that is just not cool.
  • Load values from the file system so people can add transactions in lieu of RPC or a cli.

PR author checklist

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code/examples/channel/Cargo.toml Outdated Show resolved Hide resolved
@romac romac changed the title feat(example): add example app using channels feat(example): Add example app using channels Dec 17, 2024
@romac romac marked this pull request as ready for review December 17, 2024 12:25
@romac romac merged commit add0d2a into main Dec 17, 2024
11 checks passed
@romac romac deleted the greg/app branch December 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants