Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver): Allow the driver to raise errors in some occasions #62

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

romac
Copy link
Member

@romac romac commented Nov 13, 2023

Namely:

  • When Env::get_value fails to return a value to propose
  • When the supposed proposer cannot be found in the validator set
  • When a vote's validator cannot be found in the validator set
  • When a vote's signature is invalid

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b2d63ed) 86.45% compared to head (b28e5f0) 86.67%.

Files Patch % Lines
Code/driver/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   86.45%   86.67%   +0.22%     
==========================================
  Files          25       26       +1     
  Lines        1166     1185      +19     
==========================================
+ Hits         1008     1027      +19     
  Misses        158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac merged commit 01cfa7e into main Nov 14, 2023
7 checks passed
@romac romac deleted the error-handling branch November 14, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant