Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client for getting a value and validate a proposal #43

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

romac
Copy link
Member

@romac romac commented Nov 3, 2023

Closes: #27

At the moment, this solution prevents us from integrating with async code, so we'll have to revisit it if/when the need arises, or come up with something else entirely that is sync/async-agnostic. Maybe generators, or the maybe-async crate?

@romac romac requested a review from ancazamfir November 3, 2023 16:32
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #43 (1c047e6) into romac/rust-state-machine (52d51a4) will increase coverage by 0.12%.
The diff coverage is 90.00%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #43      +/-   ##
============================================================
+ Coverage                     84.26%   84.39%   +0.12%     
============================================================
  Files                            23       24       +1     
  Lines                          1220     1236      +16     
============================================================
+ Hits                           1028     1043      +15     
- Misses                          192      193       +1     
Files Coverage Δ
Code/test/src/client.rs 100.00% <100.00%> (ø)
Code/consensus/src/executor.rs 85.80% <81.82%> (-<0.01%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@romac romac merged commit d79ecec into romac/rust-state-machine Nov 7, 2023
7 checks passed
@romac romac deleted the romac/get-value branch November 7, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant