Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Move address from SignedVote to Vote #36

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 30, 2023

Closes: #23

@romac romac force-pushed the romac/move-address branch from 155fc0c to ee55d30 Compare October 31, 2023 10:23
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #36 (cb93ff7) into romac/rust-state-machine (98d2b63) will decrease coverage by 0.56%.
The diff coverage is 86.11%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #36      +/-   ##
============================================================
- Coverage                     85.93%   85.37%   -0.56%     
============================================================
  Files                            19       20       +1     
  Lines                          1002     1025      +23     
============================================================
+ Hits                            861      875      +14     
- Misses                          141      150       +9     
Files Coverage Δ
Code/common/src/signed_vote.rs 100.00% <100.00%> (ø)
Code/common/src/vote.rs 100.00% <ø> (ø)
Code/consensus/src/executor.rs 87.76% <100.00%> (-0.16%) ⬇️
Code/round/src/message.rs 72.41% <100.00%> (ø)
Code/round/src/state.rs 98.41% <100.00%> (+0.03%) ⬆️
Code/test/src/consensus.rs 95.00% <100.00%> (ø)
Code/test/src/vote.rs 94.44% <100.00%> (+0.33%) ⬆️
Code/round/src/state_machine.rs 67.24% <84.44%> (+5.25%) ⬆️
Code/round/src/transition.rs 57.89% <57.89%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac marked this pull request as ready for review October 31, 2023 12:46
@romac romac merged commit e46a95b into romac/rust-state-machine Oct 31, 2023
7 checks passed
@romac romac deleted the romac/move-address branch October 31, 2023 13:16
romac added a commit that referenced this pull request Nov 8, 2023
* Move address from SignedVote into Vote

* Rename a few fields for better clarity

* Supply validator address to the state machine

* Move `Transition` struct into its own module

* Extract immutable data required to run the round state machine into a `RoundData` struct (#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant