Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Cleanup input/output names and align VoteKeeper to it #34

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 30, 2023

Closes: #24

@romac romac changed the base branch from main to romac/rust-state-machine October 30, 2023 10:17
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #34 (b72eeed) into romac/rust-state-machine (39a2041) will decrease coverage by 0.20%.
Report is 1 commits behind head on romac/rust-state-machine.
The diff coverage is 88.89%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #34      +/-   ##
============================================================
- Coverage                     86.00%   85.80%   -0.20%     
============================================================
  Files                            20       19       -1     
  Lines                           986      993       +7     
============================================================
+ Hits                            848      852       +4     
- Misses                          138      141       +3     
Files Coverage Δ
Code/vote/src/keeper.rs 66.67% <100.00%> (+0.76%) ⬆️
Code/consensus/src/executor.rs 87.59% <84.21%> (-1.54%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac merged commit 88c015a into romac/rust-state-machine Oct 30, 2023
7 checks passed
@romac romac deleted the romac/executor-inout branch October 30, 2023 12:21
romac added a commit that referenced this pull request Nov 8, 2023
* executor: Rename input and outputs to `Event` and `Message`

* votekeeper: Rename outputs to `Message`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

executor: Cleanup input/output names and align VoteKeeper to it
2 participants