Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code): Use more reasonable history_gossip and history_length config params for GossipSub #258

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jun 28, 2024

The GossipSub parameters override introduced in #236 lead to very high memory usage. This PR reverts them to their default values.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (642c982) to head (47a83aa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   80.90%   81.49%   +0.60%     
==========================================
  Files          75       75              
  Lines        5606     5581      -25     
==========================================
+ Hits         4535     4548      +13     
+ Misses       1071     1033      -38     
Flag Coverage Δ
integration 81.54% <100.00%> (+0.60%) ⬆️
mbt 8.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac
Copy link
Member Author

romac commented Jun 28, 2024

Ran some experiments locally with 10 nodes:

History size Heartbeat interval Graph Peak memory usage
50/500 1s 1  053 + big history + 1s interval 1.35 GB
3/5 1s 4  053 + medium history + 1s interval 105MB
2/3 2s 5  053 + small history + 2s interval 88MB

Been playing with a higher heartbeat interval after reading https://ethresear.ch/t/number-duplicate-messages-in-ethereums-gossipsub-network/19921

@romac
Copy link
Member Author

romac commented Jun 28, 2024

I have been running this branch in a 1h simulation locally with 10 nodes, and cannot see any obvious leaks.

@romac romac requested a review from greg-szabo June 28, 2024 15:42
@greg-szabo greg-szabo changed the base branch from main to romac/driver-transition July 3, 2024 18:39
@greg-szabo greg-szabo marked this pull request as ready for review July 3, 2024 18:39
@greg-szabo greg-szabo merged commit 5ae4115 into romac/driver-transition Jul 3, 2024
13 checks passed
@greg-szabo greg-szabo deleted the romac/gossip-history branch July 3, 2024 18:39
@greg-szabo
Copy link
Member

Merging this into the MovedToStep change so I can test them together.

@romac romac restored the romac/gossip-history branch July 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants