fix(code): Do not cancel prevote/precommit timeout when threshold is reached #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reached Otherwise we dont move to next round when the threshold was for `Nil`.
romac
commented
Jun 4, 2024
code/actors/src/consensus.rs
Outdated
Comment on lines
375
to
381
| // TODO - check on this. For L47 (PrecommitAny) the spec says: | ||
| // upon 2f + 1 (PRECOMMIT, hp, roundp, *) for the first time do | ||
| // schedule OnTimeoutPrecommit(hp , roundp) to be executed after timeoutPrecommit(roundp) | ||
| // If we cancel the timeout we will not move to next round | ||
| state.timers.cast(TimersMsg::CancelTimeout(timeout))?; | ||
| // | ||
| // info!("Threshold met for {threshold:?} at round {round}, cancelling {timeout}"); | ||
| // state.timers.cast(TimersMsg::CancelTimeout(timeout))?; |
There was a problem hiding this comment.
Shall we remove this whole block of commented out code altogether?
There was a problem hiding this comment.
yeah, let's remove. we should do a code walkthrough later to make sure we don't leave timers running that can cause issues.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 83.83% 83.71% -0.12%
==========================================
Files 67 67
Lines 4779 4757 -22
==========================================
- Hits 4006 3982 -24
- Misses 773 775 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
romac
commented
Jun 4, 2024
| @@ -330,57 +327,22 @@ where | |||
| } | |||
| } | |||
|
|
|||
| let check_threshold = if let DriverInput::Vote(vote) = &input { | |||
There was a problem hiding this comment.
I always felt like this was a big hack when I added it, so I am glad we can actually likely remove it altogether.
romac
force-pushed
the
romac/fix-threshold-timeout-cancel
branch
from
f9c7d0f to
e99dcea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we dont move to next round when the threshold was for
Nil.